IPAM Address Support for Bloxone Ansible v2 #55
Conversation
unasra
changed the title
|
Missing change logs and deprecation notices for this object . Earlier this module was termed as ipv4_reservation ! |
plugins/modules/ipam_address.py
Outdated
| state: "present" | ||
| register: subnet | ||
|
|
||
| - name: Create a Address |
There was a problem hiding this comment.
Examples should have only the required tasks. Here , the tasks for creation of parents i.e. Ip Space and Subnet , one task containing the creation of the address with a few relevant fields and another for the deletion of the address should be sufficient. Others can be removed !!
plugins/modules/ipam_address_info.py
Outdated
| state: "present" | ||
| register: subnet | ||
|
|
||
| - name: Create A Address |
There was a problem hiding this comment.
As this is an example for Info , remove all the create statements here , just keep the get/ info statements .
| @@ -0,0 +1,2 @@ | |||
| --- | |||
| dependencies: [setup_address] | |||
There was a problem hiding this comment.
Dependencies include the setup required used in the main file for the creation of an address , something like ip space or subnet !
plugins/modules/ipam_address_info.py
Outdated
| - name: Get information about the Address by tag | ||
| infoblox.bloxone.ipam_address_info: | ||
| tag_filters: | ||
| region : "eu" |
There was a problem hiding this comment.
| region : "eu" | |
| location : "site-1" |
plugins/modules/ipam_address_info.py
Outdated
| - name: Get information about the Address by ID | ||
| infoblox.bloxone.ipam_address_info: | ||
| id: "{{ address.id }}" | ||
| register: address_info |
There was a problem hiding this comment.
Registering the result of the object is not important as it is not being used anywhere . Hence all the registers can be removed.
| filters: { | ||
| address: "10.0.0.6", | ||
| space: "{{ _ip_space.id }}", | ||
| hwaddr: "00:11:22:33:44:55" |
There was a problem hiding this comment.
The address can be filtered with just address and space , hwaddr isnt required here !
The same applies for all the subsequent tasks below.
|
|
||
| always: | ||
| # Cleanup if the test fails | ||
| - name: Delete a Subnet |
There was a problem hiding this comment.
Missing cleanup call for address.
| api_key: "{{ api_key }}" | ||
| block: | ||
| # Basic tests for Address Block | ||
| - name: Create A Address |
There was a problem hiding this comment.
| - name: Create A Address | |
| - name: Create an Address |
| infoblox.bloxone.ipam_address: | ||
| address: "10.0.0.3" | ||
| space: "{{ _ip_space.id }}" | ||
| tags: |
There was a problem hiding this comment.
Create a random tag ,as done in other objects .
| - address_info.objects | length != 0 | ||
|
|
||
| always: | ||
| # Cleanup if the test fails |
There was a problem hiding this comment.
Cleanup required for address
No description provided.